-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring as many validation tests into the schema logic as possible #516
Comments
I'll do an initial pass down the notes in this sheet. |
@rhiaro - I've been reviewing this spreadsheet again. I'm satisfied that we have brought as many local tests into the schema as we can... or we have dedicated open tickets for remaining logic to be added. The outstanding question is: how complete do you think the valid and invalid test data needs to be in the repo? Are we looking at - for example - at least one valid and invalid file per field? Or should we aim to test all constraints on every field and object (i.e. put a 'y' in column F for each row). I want to get this work set up for myself, @odscrachel and @kathryn-ods over the next day or two. |
We should aim to test all constraints on every field and object. |
OK. It's fine. It's finite. We can do this. |
Documentation on adding test data is now in the handbook. Valid files are being renamed to remove fermentcat_ and tecido_ prefixes. PR #616 |
closing as all possible tests have now been added in! |
JSON schema 2020-12 allows more validation logic to be included.
We will use this spreadsheet to track the validation tests which are being built into the schema.
The text was updated successfully, but these errors were encountered: