Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider including secondary GPS data in spec: speed, course, altitude, verticalAccuracy #59

Closed
ezheidtmann opened this issue Sep 12, 2018 · 10 comments · Fixed by #653
Closed
Labels
enhancement New feature or request Provider Specific to the Provider API
Milestone

Comments

@ezheidtmann
Copy link

These fields are provided by both dominant smartphone platforms, but they can be null. I believe the field names should be defined in the spec, but allowed to be empty. Proposed definitions:

  • speed: Instantaneous speed in meters per second. Ref: iOS Android
  • course: The direction in which the device is traveling, measured in degrees and relative to due north. Ref: iOS Android
  • altitude: The altitude, measured in meters. Ref: iOS Android
  • verticalAccuracy: The uncertainty of the altitude value, in meters. Ref: iOS Android

Example point:

    {
        "type": "Feature",
        "properties": {
            "timestamp": 1529968782.421409,
            "speed": 5.23,
            "course": 290,
            "altitude": 40,
            "verticalAccuracy": 30
        },
        "geometry": {
            "type": "Point",
            "coordinates": [
                -118.46710503101347,
                33.9909333514159
            ]
        }
    }
@hunterowens
Copy link
Collaborator

👍 from me. @ezheidtmann do you want to PR?

@thekaveman this seems like something for a 0.2.0 release?

@marie-x
Copy link
Collaborator

marie-x commented Feb 26, 2019

This is covered in Agency 0.3.0. I don't know if we want to go back and update Provider.

@marie-x
Copy link
Collaborator

marie-x commented Mar 4, 2019

What say ye @ezheidtmann ?

@ezheidtmann
Copy link
Author

I'd advocate for including these fields as optional in Provider feeds.

@sarob sarob added enhancement New feature or request Provider Specific to the Provider API labels Dec 19, 2019
@schnuerle
Copy link
Member

Sounds good to add these to provider too. What do you think @thekaveman @Karcass?

@schnuerle schnuerle modified the milestones: Future, 1.1.0 Sep 2, 2020
@marie-x
Copy link
Collaborator

marie-x commented Sep 3, 2020

Yes, it would further align Agency and Provider.

@schnuerle
Copy link
Member

Would anyone like to do a PR for this and make all the fields optional to ensure it's not breaking for 1.1.0? Otherwise we can push to next release. See PR #73 for some ideas.

@schnuerle
Copy link
Member

I think this may require some more discussion and work and could be a breaking change so moving to 2.0.0.

@schnuerle schnuerle modified the milestones: 1.1.0, 2.0.0 Nov 18, 2020
@schnuerle schnuerle removed this from the 2.0.0 milestone Jul 6, 2021
@schnuerle
Copy link
Member

Being addressed by #653. Please review that PR and leave comments there if interested.

@schnuerle
Copy link
Member

schnuerle commented Jul 23, 2021

We will be addressing most of this in 1.2.0 with the #653 PR. The only thing missing will be vertical accuracy, which we have created a new Issue for at #661.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Provider Specific to the Provider API
Projects
None yet
6 participants