Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination doesn't work the same here as in JSON API #49

Closed
aickin opened this issue Sep 12, 2018 · 2 comments
Closed

Pagination doesn't work the same here as in JSON API #49

aickin opened this issue Sep 12, 2018 · 2 comments

Comments

@aickin
Copy link
Contributor

aickin commented Sep 12, 2018

In the provider API definition, it says that "pagination must comply with the JSON API specification", but the JSON API spec says:

Pagination links MUST appear in the links object that corresponds to a collection. To paginate the primary data, supply pagination links in the top-level links object.

This spec puts the first, last, prev, next URLs at the top level of the response, rather than inside in a links object. I feel like either this spec should use the links object or not say that paginations complies with JSON API.

@thekaveman
Copy link
Collaborator

@aickin good catch, that was just me being lazy and not reading that spec close enough. Happy to take a PR to fix this if you'd like.

Also see our discussion on #46 where this certainly matters. There will be an incoming PR for exploring that idea more, shortly.

@thekaveman
Copy link
Collaborator

@aickin can you take a look at the PR and see if this makes sense with your understanding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants