Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifiers.doi_pattern setting is flagged as translatable #2088

Closed
mauromsl opened this issue Mar 16, 2021 · 0 comments · Fixed by #2272
Closed

Identifiers.doi_pattern setting is flagged as translatable #2088

mauromsl opened this issue Mar 16, 2021 · 0 comments · Fixed by #2272
Labels
bug Something's not working
Milestone

Comments

@mauromsl
Copy link
Member

Describe the bug
The setting doi_pattern is flagged as ìs_translatable=true which seems incorrect. This leads to a number of problems on journals that had I18N enabled at some point, since they now might not have a setting value set for their default language (e.g if the language context of the journal manager was not set to the default language at the time when the setting was first entered)

As a result, those journals now raise an error whenever the setting is fetched in the default language context (or any other language even)

Janeway version
v1.3.9

Expected behavior
The setting should be flagged as not translatable at installation time.
A migration is required to fix current installs where:

  • A value is set for the default language
  • The installed setting is_translatable attribute has to change to false
@mauromsl mauromsl added the bug Something's not working label Mar 16, 2021
@ajrbyers ajrbyers added this to the 1.4 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants