Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Sidecar terminator ignore the exit code of the sidecar container #1285

Closed
zmberg opened this issue May 16, 2023 · 2 comments · Fixed by #1303
Closed

[feature request] Sidecar terminator ignore the exit code of the sidecar container #1285

zmberg opened this issue May 16, 2023 · 2 comments · Fixed by #1303
Assignees
Labels
help wanted Extra attention is needed kind/feature-request
Milestone

Comments

@zmberg
Copy link
Member

zmberg commented May 16, 2023

What would you like to be added:
OpenKruise job sidecar terminator controller watches and terminates sidecar containers for such job-type Pods when its main containers completed, details: JobSidecarTerminator.

But, the above feature contains certain limitation of "Your sidecar container must respond the SIGTERM signal, and the entrypoint should exit 0 when received this signal." If the exit code of the sidecar container is non-zero, Job will judge the pod failure.

So i hope JobSidecarTerminator can solve the above problem and ensure that the job is completed normally even if the exit code of the sidecar container is non-zero.

@zmberg zmberg added the help wanted Extra attention is needed label May 30, 2023
@zmberg zmberg unassigned zmberg and veophi May 30, 2023
@diannaowa
Copy link
Contributor

diannaowa commented Jun 1, 2023

This is my workaround: #1303

@zmberg PTAL

@zmberg
Copy link
Member Author

zmberg commented Jun 8, 2023

/assign @diannaowa

@zmberg zmberg modified the milestone: v1.5 Jun 8, 2023
@zmberg zmberg modified the milestones: v1.5, 1.6 Mar 7, 2024
@github-project-automation github-project-automation bot moved this to Done in Roadmap Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/feature-request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants