Skip to content
This repository has been archived by the owner on May 23, 2019. It is now read-only.

Support for Italian language #42

Closed
llegovich opened this issue Jan 31, 2019 · 6 comments
Closed

Support for Italian language #42

llegovich opened this issue Jan 31, 2019 · 6 comments

Comments

@llegovich
Copy link

Would like for the Italian language. I'm italian, how can I contribute? Thx

@ghys
Copy link
Member

ghys commented Feb 5, 2019

Hi, it's a somewhat involved process. You'll have to:

  1. Provide translations in Italian to the semantic tags here:
    https://github.com/openhab/openhab-core/tree/master/bundles/org.openhab.core.semantics/src/main/resources
    (that is, add a tags_it.properties file through a PR)

  2. Provide training data (including tests) and translations for greetings & answers with a PR to this repository. Basically what was done for Dutch in Dutch translations #32.

@llegovich
Copy link
Author

Hi, I'm sorry but I'm new to github and don't know the right way to create the pull request. I have the files translated, could you guide me in uploading them?
thanks.

@kubawolanin
Copy link

I have the files translated, could you guide me in uploading them?

Check out these step-by-step tutorials:
https://help.github.com/articles/set-up-git/
https://help.github.com/articles/fork-a-repo/

@llegovich
Copy link
Author

llegovich commented Apr 6, 2019

I have created the pull request. Please review and merge. Thx.

@kaikreuzer
Copy link
Member

That's awesome @llegovich, thanks!
I am just afraid that someone should have told you that the code has meanwhile moved to https://github.com/openhab/openhab-webui/tree/master/bundles/org.openhab.ui.habot (@ghys we should consider to add big notes on the readme of the old repos and maybe rename them, wdyt?).

@llegovich May I thus ask you to check out https://github.com/openhab/openhab-webui and create your PR against this? (should really be just a move of your files to that repo, I don't think it should be much effort, otherwise I would not dare to ask ;-)). Thanks!

@llegovich
Copy link
Author

Hi @kaikreuzer I have created the pull request on the new repo. Hope it's ok.
thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants