Offline installation enhancements #950
Conversation
Signed-off-by: Markus Storm <[email protected]>
Signed-off-by: Markus Storm <[email protected]>
Signed-off-by: Markus Storm <[email protected]>
Signed-off-by: Markus Storm <[email protected]>
Signed-off-by: Markus Storm <[email protected]>
Signed-off-by: Markus Storm <[email protected]>
Signed-off-by: Markus Storm <[email protected]>
Signed-off-by: Markus Storm <[email protected]>
|
@mstormi did you consider that the base image might not contain everything you need to compile the zram packages? My requirements would be
If really needed, we could separate the compilation step out and build deb packes for zram separately. Much simpler would be to clone on build and compile during first-boot script (though I never liked the compiler toolchains on my home server, and it is not that complicated to create packages with packaging helper tools...) For req 2 we might need to cache some Deb packages (but sure what is missing, might be a set of dependencies required) |
|
I'm targeting to (git-)download the (source only) code on image build and to compile during installation. Effectively it's 2 routines, first (download) one is called on image build AND installation, second (install) on installation only. Still busy double-checking but seems compiler tools are part of both images so compilation on install on target system should work. |
Signed-off-by: Markus Storm <[email protected]>
Signed-off-by: Markus Storm <[email protected]>
Signed-off-by: Markus Storm <[email protected]>
Signed-off-by: Markus Storm <[email protected]>
Signed-off-by: Markus Storm <[email protected]>
| @@ -36,8 +36,8 @@ frontail_setup() { | |||
| if [ -d "$frontail_base" ]; then | |||
| cond_redirect npm uninstall -g frontail | |||
| fi | |||
| if ! cond_redirect npm install -g frontail; then echo "FAILED (frontail)"; return 1; fi | |||
| cond_redirect npm update -g frontail | |||
| if ! cond_redirect npm install --force -g frontail; then echo "FAILED (frontail)"; return 1; fi | |||
There was a problem hiding this comment.
Why do we need --force here? It will enforce new download, correct?
There was a problem hiding this comment.
not that I am aware, but we need it simply because without it'll break install when Inet is unavailable. Haven't found a better way around so far.
| cond_redirect apt-get install -y -q --no-install-recommends make libattr1-dev | ||
|
|
||
| mkdir -p "$1" | ||
| cd $1 || return 1; |
There was a problem hiding this comment.
Like that defensive way of coding!
There was a problem hiding this comment.
Kudos go to shellcheck :-|
| @@ -1,8 +1,23 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| install_zram_code() { | |||
There was a problem hiding this comment.
fetch zram source code and dependencies to location given in $1 (will create folder)
There was a problem hiding this comment.
I added a comment what the function does/has as arguments like Ethan does
Please do. Note it'll not compile there but only ever in init_zram_mounts() when that is called during installation. |
Signed-off-by: Markus Storm <[email protected]>
Signed-off-by: Markus Storm <[email protected]>
|
Installing via build.bash will not work. Will provide a hook where you can add the required stuff. |
Fixes #825
Signed-off-by: Markus Storm [email protected]