Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct references to Azul java versions #879

Closed
mstormi opened this issue May 10, 2020 · 16 comments · Fixed by #993
Closed

correct references to Azul java versions #879

mstormi opened this issue May 10, 2020 · 16 comments · Fixed by #993
Labels
awaiting feedback Waiting for additional information java Related to java

Comments

@mstormi
Copy link
Contributor

mstormi commented May 10, 2020

We download and use the "Community" version for both, x86 and ARM.

Code and docs however sometimes still refer to these as "Enterprise" and "Embedded" version s, respectively.

Need to remove/correct these referrals (java-jre.bash, docs/openhabian.md)

@ecdye
Copy link
Member

ecdye commented May 10, 2020

No, the ARM builds are actually embedded. Azul has made embedded builds available like all of their community builds.

@mstormi
Copy link
Contributor Author

mstormi commented May 10, 2020

Err, ok. The current download link contains a "community"part.
And it's not about the code but about licensing, isn't it? Those distributed as 'community' fall under 'community' licensing (=no restrictions, essentially), or am I mistaken ?

@ecdye
Copy link
Member

ecdye commented May 10, 2020

I'm actually not sure about that part. I would need to look into it, I mostly just re-implemented the download using the API. You can prove that it is actually a embedded build by looking at the links that it returns for downloads from the API it is pulling from the embedded folder.

@ecdye
Copy link
Member

ecdye commented May 11, 2020

And it's not about the code but about licensing, isn't it?

I think that Embedded builds are mostly just optimized for SoC's like the RPi. I could be wrong though. I'll look into it more tomorrow morning.

@mstormi
Copy link
Contributor Author

mstormi commented May 11, 2020

Yes, Embedded essentially is ARM and Enterprise is x86.
I believe Community isn't a real build but just the same Embedded/Enterprise packages but with a different license attached.

@ecdye
Copy link
Member

ecdye commented May 11, 2020

So I got in contact with Azul and their rep is going to get me in touch with the product manager to see if we can work something out.

@ecdye
Copy link
Member

ecdye commented May 12, 2020

So, Azul's PM team is now aware of the issue and is looking into a fix. I'll update when I hear anything else.

@mstormi
Copy link
Contributor Author

mstormi commented May 16, 2020

FYI

[12:51:58] openhabian@openhabianpi:~$ java -version
openjdk version "1.8.0_222"
OpenJDK Runtime Environment (Zulu8.40.0.178-CA-linux_aarch32hf) (build 1.8.0_222-b178)
OpenJDK Client VM (Zulu8.40.0.178-CA-linux_aarch32hf) (build 25.222-b178, mixed mode, Evaluation)
                                                                                      ^^^^^^^^^^

@ecdye
Copy link
Member

ecdye commented May 17, 2020

It has always said that.

@mstormi mstormi added the awaiting feedback Waiting for additional information label May 18, 2020
@holgerfriedrich holgerfriedrich added the java Related to java label May 22, 2020
@mstormi
Copy link
Contributor Author

mstormi commented May 23, 2020

any feedback from Azul ? Do we need to do anything ?

@ecdye
Copy link
Member

ecdye commented May 24, 2020

Nothing from them as of yet.

@mstormi
Copy link
Contributor Author

mstormi commented Jun 14, 2020

so assuming we will not get any answer any more, would we need to change anything or rather close this issue?

@ecdye
Copy link
Member

ecdye commented Jun 14, 2020

I don't believe anything needs to be done. I will keep an eye out but I doubt that I will get a response at this point. Hopefully it will be fixed some day.

@mstormi
Copy link
Contributor Author

mstormi commented Jun 15, 2020

Will close for the time being, reopen it if there's news.

@mstormi mstormi closed this as completed Jun 15, 2020
@ecdye
Copy link
Member

ecdye commented Jun 20, 2020

I just looked today, no email but a fix for the API has been issued and I will include it in #990.

@holgerfriedrich
Copy link
Member

I just looked today, no email but a fix for the API has been issued and I will include it in #990.

Hi Ethan, can you pls do it on a separate PR? #990 should be more or less rewrite and free of side effects on actual features.

ecdye added a commit to ecdye/openhabian that referenced this issue Jun 21, 2020
Additonally fix Java installation output.

Fixes openhab#878
Fixes openhab#879

Signed-off-by: Ethan Dye <[email protected]>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 21, 2020
Additionally fix Java installation output.

Fixes openhab#878
Fixes openhab#879

Signed-off-by: Ethan Dye <[email protected]>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 21, 2020
Additionally fix Java installation output.

Fixes openhab#878
Fixes openhab#879

Signed-off-by: Ethan Dye <[email protected]>
mstormi pushed a commit that referenced this issue Jun 23, 2020
Additionally fix Java installation output.

Fixes #878
Fixes #879

Signed-off-by: Ethan Dye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback Waiting for additional information java Related to java
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants