-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo dynamic image URLs #317
Conversation
Signed-off-by: John Cocula <[email protected]>
Funny URLs :) But do we really need all 8 of them in the demo file? Now that you already experimented with this new feature, would you add another PR here? Otherwise I can have a look... |
Signed-off-by: John Cocula <[email protected]>
Thanks for your input. I've shortened the list a bit. I don't know a good way to make the default URL feature more prominent in the demo but would appreciate suggestions. I will definitely submit a PR to sitemap.md. I think this is a good enhancement for sitemap-based UIs, but as we were discussing here, something in addition should be provided for non-sitemap-based UIs. |
Related PRs: * eclipse-archived/smarthome#2412 * openhab/openhab-distro#317 Signed-off-by: John Cocula <[email protected]>
Related PRs: * eclipse-archived/smarthome#2412 * openhab/openhab-distro#317 Signed-off-by: John Cocula <[email protected]>
I am actually not sure whether we should add this feature to the demo files at all. But we should probably first finish the discussion on the implementation itself. |
Related PRs: * eclipse-archived/smarthome#2412 * openhab/openhab-distro#317 Signed-off-by: John Cocula <[email protected]>
Ok, having had a closer look at the implementation in eclipse-archived/smarthome#2412, I merged it and I am also fine with adding this example to the demo files - will merge as soon as the next ESH stable is flowing to OH! |
See eclipse-archived/smarthome#2412
Signed-off-by: John Cocula [email protected]