Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo dynamic image URLs #317

Merged
merged 2 commits into from
Nov 18, 2016
Merged

Conversation

watou
Copy link
Contributor

@watou watou commented Nov 5, 2016

See eclipse-archived/smarthome#2412

Signed-off-by: John Cocula [email protected]

Signed-off-by: John Cocula <[email protected]>
@ThomDietrich
Copy link
Member

ThomDietrich commented Nov 6, 2016

Funny URLs :) But do we really need all 8 of them in the demo file?
Also according to the referenced PR the url parameter serves as a fallback image. Didn't get clear from this example...

Now that you already experimented with this new feature, would you add another PR here? Otherwise I can have a look...
https://github.com/openhab/openhab-docs/blob/gh-pages/features/sitemap.md

@watou
Copy link
Contributor Author

watou commented Nov 6, 2016

Thanks for your input. I've shortened the list a bit. I don't know a good way to make the default URL feature more prominent in the demo but would appreciate suggestions. I will definitely submit a PR to sitemap.md.

I think this is a good enhancement for sitemap-based UIs, but as we were discussing here, something in addition should be provided for non-sitemap-based UIs.

watou added a commit to watou/openhab-docs that referenced this pull request Nov 6, 2016
ThomDietrich pushed a commit to openhab/openhab-docs that referenced this pull request Nov 6, 2016
@kaikreuzer
Copy link
Member

I am actually not sure whether we should add this feature to the demo files at all.
It is nothing I would want to promote as a feature that should be used - it is rather something for the ticks&tricks section how to solve certain situations, if nothing else helps...

But we should probably first finish the discussion on the implementation itself.

ThomDietrich pushed a commit to ThomDietrich/openhab-docs that referenced this pull request Nov 8, 2016
@kaikreuzer
Copy link
Member

Ok, having had a closer look at the implementation in eclipse-archived/smarthome#2412, I merged it and I am also fine with adding this example to the demo files - will merge as soon as the next ESH stable is flowing to OH!

@kaikreuzer kaikreuzer merged commit 8eea2de into openhab:master Nov 18, 2016
@kaikreuzer kaikreuzer modified the milestone: 2.0.0.b5 Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants