SafeCaller usage: ThingManager impl.

[maggu2810]

WRT the findings in #861 and #829 I am interested if there are any need to use the safecaller in the thing manager implementation on all its places.

I realized that the creation / update of thousand of things takes a lot of time.

openhab-core/bundles/org.openhab.core.thing/src/main/java/org/eclipse/smarthome/core/thing/internal/ThingManagerImpl.java

Lines 480 to 481 in abab07d

	safeCaller.create(thingHandlerFactory, ThingHandlerFactory.class).build()
	.removeThing(thing.getUID());

openhab-core/bundles/org.openhab.core.thing/src/main/java/org/eclipse/smarthome/core/thing/internal/ThingManagerImpl.java

Line 511 in abab07d

safeCaller.create(thingHandler, ThingHandler.class).build().thingUpdated(thing);

openhab-core/bundles/org.openhab.core.thing/src/main/java/org/eclipse/smarthome/core/thing/internal/ThingManagerImpl.java

Lines 761 to 770 in abab07d

	safeCaller.create(thingHandler, ThingHandler.class).onTimeout(() -> {
	logger.warn("Initializing handler for thing '{}' takes more than {}ms.", thingHandler.getThing().getUID(),
	SafeCaller.DEFAULT_TIMEOUT);
	}).onException(e -> {
	ThingStatusInfo statusInfo = buildStatusInfo(ThingStatus.UNINITIALIZED,
	ThingStatusDetail.HANDLER_INITIALIZING_ERROR, e.getMessage());
	setThingStatus(thingHandler.getThing(), statusInfo);
	logger.error("Exception occurred while initializing handler of thing '{}': {}",
	thingHandler.getThing().getUID(), e.getMessage(), e);
	}).build().initialize();

openhab-core/bundles/org.openhab.core.thing/src/main/java/org/eclipse/smarthome/core/thing/internal/ThingManagerImpl.java

Lines 809 to 832 in abab07d

	safeCaller.create(() -> {
	ThingHandler thingHandler = thing.getHandler();
	thingHandlerFactory.unregisterHandler(thing);
	if (thingHandler != null) {
	thingHandler.setCallback(null);
	}
	thing.setHandler(null);
	boolean enabled = !isDisabledByStorage(thing.getUID());
	ThingStatusDetail detail = enabled ? ThingStatusDetail.HANDLER_MISSING_ERROR : ThingStatusDetail.DISABLED;
	setThingStatus(thing, buildStatusInfo(ThingStatus.UNINITIALIZED, detail));
	thingHandlers.remove(thing.getUID());
	synchronized (thingHandlersByFactory) {
	final Set<ThingHandler> thingHandlers = thingHandlersByFactory.get(thingHandlerFactory);
	if (thingHandlers != null) {
	thingHandlers.remove(thingHandler);
	if (thingHandlers.isEmpty()) {
	thingHandlersByFactory.remove(thingHandlerFactory);
	}
	}
	}
	}, Runnable.class).build().run();

openhab-core/bundles/org.openhab.core.thing/src/main/java/org/eclipse/smarthome/core/thing/internal/ThingManagerImpl.java

Lines 851 to 857 in abab07d

	safeCaller.create(thingHandler, ThingHandler.class).onTimeout(() -> {
	logger.warn("Disposing handler for thing '{}' takes more than {}ms.", thingHandler.getThing().getUID(),
	SafeCaller.DEFAULT_TIMEOUT);
	}).onException(e -> {
	logger.error("Exception occurred while disposing handler of thing '{}': {}",
	thingHandler.getThing().getUID(), e.getMessage(), e);
	}).build().dispose();

@kaikreuzer Do you agree that your comment is also valid at this place?

I do not see any reason to create a proxy at all.

[kaikreuzer]

@kaikreuzer Do you agree that your comment is also valid at this place?

As far as I can overlook it, yes, I would agree that it is valid at those places as well.
@SJKA as the original author might be the best person to comment on it, though.