Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isom-1720 bug back to top doesnt work on template #995

Merged

Conversation

adriangohjw
Copy link
Contributor

Problem

Closes https://linear.app/ogp/issue/ISOM-1720/bug-back-to-top-doesnt-work-on-template

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Findings

  • Bug occured after b7f73e2
  • doesn't seem to be anything relating to next/link directly, and couldn't find anything online about how adding will break nextjs
  • nextjs provides a way to add preconnect and dnsprefetch. However, it did not state that it must be done this way. In addition, this is only available in React19 which we aren't on.
  • Decided to not spend more time on this issue

Bug Fixes:

  • hotfix: replace next/link with pure

Tests

  1. publish a new build
  2. go to a collection and click "back to top" under the filters -> it should work
  3. go to a content page in a folder and click on "back to top" in the siderail -> it should work

@adriangohjw adriangohjw added the bug Something isn't working label Jan 16, 2025
@adriangohjw adriangohjw self-assigned this Jan 16, 2025
@adriangohjw adriangohjw requested a review from a team as a code owner January 16, 2025 15:15
Copy link

linear bot commented Jan 16, 2025

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 16, 2025

Datadog Report

Branch report: adriangohjw/isom-1720-bug-back-to-top-doesnt-work-on-template
Commit report: c663f28
Test service: isomer-studio

✅ 0 Failed, 257 Passed, 36 Skipped, 46.27s Total Time
➡️ Test Sessions change in coverage: 1 no change

@adriangohjw adriangohjw merged commit 3f2fa9c into main Jan 20, 2025
16 of 18 checks passed
@adriangohjw adriangohjw deleted the adriangohjw/isom-1720-bug-back-to-top-doesnt-work-on-template branch January 20, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants