-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(url): show full urls everywhere in UI #942
Conversation
do this so that it shows a nice loading box
Datadog ReportBranch report: ✅ 0 Failed, 232 Passed, 36 Skipped, 38.49s Total Time |
729fea8
to
0a63487
Compare
@@ -1,6 +1,7 @@ | |||
import { Suspense } from "react" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had a brief discussion with Chin and it seems like it will be too long, especially when considering the parent permalink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually the figma design is to have the infobox and not this, refer to the figma here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea that's fine. What I felt helped was having the <example.com>/ or the site domain in front
For now a simple fix would be to keep the your-site.gov.sg/
in front of the permalink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shuold change everything at once but idt that should be a blocker here
...tudio/src/features/editing-experience/components/CreateCollectionPageModal/DetailsScreen.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving first, should follow up with future PR to add the site domain prefix
Problem
Some places don't show the full UI but we should always show the full UI everywhere. this also fixes a bug with the page settings modal where we were calling the wrong function for the close button
Solution
Suspense
so that we can load in the folder setings modal quicklyChecks
Video
Screen.Recording.2024-12-19.at.10.59.06.PM.mov