feat: logo cloud #928
Merged
feat: logo cloud #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add base logo cloud component
Datadog ReportBranch report: ✅ 0 Failed, 232 Passed, 36 Skipped, 46.79s Total Time 🔻 Code Coverage Decreases vs Default Branch (1)
|
adriangohjw
reviewed
Dec 11, 2024
There was a problem hiding this comment.
curious - why aren't we defining the schema packages/components/src/interfaces/complex/ ?
saw that it's fixed in #930
packages/components/src/templates/next/components/complex/LogoCloud/LogoCloud.stories.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/templates/next/components/complex/LogoCloud/LogoCloud.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/templates/next/components/complex/LogoCloud/LogoCloud.tsx
Outdated
Show resolved
Hide resolved
adriangohjw
approved these changes
Dec 11, 2024
adriangohjw
reviewed
Dec 17, 2024
| <div className="px-10 py-12"> | ||
| <div className="flex flex-col gap-4"> | ||
| <p className="prose-headline-base-medium self-center text-base-content-light"> | ||
| {title ?? "With support from these agencies"} |
There was a problem hiding this comment.
btw title is required and won't be falsy? just checking if this is just a preventive measures?
There was a problem hiding this comment.
yes defensive! reason why is because this is written to disk and read back (+ done manually)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
we want to add a logo cloud for agencies - this will mostly be a collection of images
Solution