Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collection tags): frontend changes for tags in collection #911

Merged
merged 5 commits into from
Dec 20, 2024
Merged

feat(collection tags): frontend changes for tags in collection #911

merged 5 commits into from
Dec 20, 2024

Conversation

seaerchin
Copy link
Contributor

Problem

We need to support tagging in our collections for the CLS use case. this PR adds the initial collection tags in

Solution

  1. Add an internal Tag component for use
  2. Add this Tag to the CollectionCard

@seaerchin seaerchin requested a review from a team as a code owner December 2, 2024 08:51
@vercel Vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 5:28am

@seaerchin seaerchin marked this pull request as draft December 2, 2024 08:56
@seaerchin seaerchin force-pushed the feat/collection-tags branch from f62747b to 25815eb Compare December 2, 2024 09:22
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Dec 2, 2024 •
edited
Loading

Datadog Report

Branch report: feat/collection-tags
Commit report: 15da4b1
Test service: isomer-studio

✅ 0 Failed, 232 Passed, 36 Skipped, 40.2s Total Time
➡️ Test Sessions change in coverage: 1 no change

@seaerchin seaerchin marked this pull request as ready for review December 2, 2024 09:27
@seaerchin seaerchin force-pushed the feat/collection-tags branch from 884866f to cd8b98d Compare December 3, 2024 09:32
@seaerchin seaerchin requested review from harishv7 and a team December 4, 2024 09:40
@seaerchin seaerchin force-pushed the feat/collection-tags branch from 31c1d87 to 4dccb22 Compare December 17, 2024 08:01
@seaerchin Graphite App
Copy link
Contributor Author

seaerchin commented Dec 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 17, 2024
Merged
Merged
Merged
@seaerchin Graphite App
Copy link
Contributor Author

seaerchin commented Dec 20, 2024 •
edited
Loading

Merge activity

  • Dec 19, 10:18 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 19, 10:19 PM EST: A user merged this pull request with Graphite.

@seaerchin seaerchin merged commit 365a58c into main Dec 20, 2024
18 of 20 checks passed
@seaerchin seaerchin deleted the feat/collection-tags branch December 20, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harishv7 harishv7 harishv7 approved these changes

@adriangohjw adriangohjw Awaiting requested review from adriangohjw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seaerchin @harishv7 @adriangohjw