replace with ResourceType for SSOT #838

adriangohjw · 2024-10-27T21:02:37Z

Problem

Currently values are hardcoded

Breaking Changes

Improvements:

single source of truth by importing them everywhere instead of hardcoding values

vercel · 2024-10-27T21:02:40Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
isomer-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 29, 2024 9:28am

datadog-opengovsg · 2024-10-27T21:06:23Z

Branch report: adriangohjw/refactor-ResourceType-to-use-const
Commit report: 28098f0
Test service: isomer-studio

✅ 0 Failed, 167 Passed, 34 Skipped, 34.23s Total Time
➡️ Test Sessions change in coverage: 1 no change

…ngohjw/refactor-ResourceType-to-use-const

replace with ResourceType for SSOT

e98efb9

adriangohjw added the enhancement New feature or request label Oct 27, 2024

adriangohjw self-assigned this Oct 27, 2024

adriangohjw requested a review from a team as a code owner October 27, 2024 21:02

adriangohjw temporarily deployed to staging October 27, 2024 21:02 — with GitHub Actions Inactive

Merge branch 'main' of https://github.com/opengovsg/isomer into adria…

29f5d4e

…ngohjw/refactor-ResourceType-to-use-const

vercel bot deployed to Preview October 29, 2024 09:23 View deployment

adriangohjw temporarily deployed to staging October 29, 2024 09:23 — with GitHub Actions Inactive

harishv7 approved these changes Nov 1, 2024

View reviewed changes

adriangohjw merged commit 4dd4e28 into main Nov 1, 2024
18 checks passed

adriangohjw deleted the adriangohjw/refactor-ResourceType-to-use-const branch November 1, 2024 04:57