Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article layout is not using Isomer Next colour and type tokens #1067

Merged

Conversation

sehyunidaaa
Copy link
Contributor

@sehyunidaaa sehyunidaaa commented Feb 3, 2025

Problem

  • The article layout wasn't using the right tokens, it was using the old tailwind tokens. So the typography was a little off from other layouts.
  • The title in the article layout is smaller than the Section Title.

Closes [ISO-161]

image

This is with the section title:
image

Solution

@sehyunidaaa sehyunidaaa requested a review from a team as a code owner February 3, 2025 03:39
Copy link

linear bot commented Feb 3, 2025

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Feb 3, 2025

Datadog Report

Branch report: sehyun/iso-161-section-heading-is-too-big-on-article-page
Commit report: 753b567
Test service: isomer-studio

✅ 0 Failed, 266 Passed, 36 Skipped, 49.63s Total Time
➡️ Test Sessions change in coverage: 1 no change

@seaerchin seaerchin enabled auto-merge (squash) February 3, 2025 05:05
@seaerchin seaerchin disabled auto-merge February 3, 2025 05:05
@seaerchin seaerchin merged commit b2bb557 into main Feb 3, 2025
18 checks passed
@seaerchin seaerchin deleted the sehyun/iso-161-section-heading-is-too-big-on-article-page branch February 3, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants