Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/admin create index page temp workabout #1065

Merged
merged 18 commits into from
Feb 3, 2025

Conversation

adriangohjw
Copy link
Contributor

@adriangohjw adriangohjw commented Jan 31, 2025

Problem

Currently, migrators depend on isoengineers to create the index page, which consumes engineering bandwidth and leads to costly context switching.

Since the feature for agency users to customize the index page is unlikely to be released soon, this serves as a temporary workaround to reduce the engineering load.

Note: This is an admin-only interim solution until the customizable index page is fully developed.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Features:

  • add a "Add index page" button for folders and collections for isomer admins

Before & After Screenshots

Screen.Recording.2025-02-01.at.6.20.33.AM.mov

Tests

Non Isomer admins should not see the button

  1. login with a non-isomer admin account e.g. [email protected]
  2. go inside a folder -> you should not see the new button
  3. go inside a collection -> you should not see the new button

Isomer admins should see the button

  1. login with a isomer-admin account e.g. [email protected]
  2. go inside a folder without an index page
    • you should see the button
    • clicking on the button should create an index page
    • opening the index page in json editor mode should show correct values
    • button should be disabled after the index page is created
    • button should still be disabled after reloading the page
  3. repeat step 2 for collection

@adriangohjw adriangohjw added the enhancement New feature or request label Jan 31, 2025
@adriangohjw adriangohjw self-assigned this Jan 31, 2025
@adriangohjw adriangohjw requested a review from a team as a code owner January 31, 2025 22:26
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 31, 2025

Datadog Report

Branch report: feat/admin-create-index-page-temp-workabout
Commit report: e7a8fb5
Test service: isomer-studio

✅ 0 Failed, 266 Passed, 36 Skipped, 45.65s Total Time
➡️ Test Sessions change in coverage: 1 no change

@@ -534,4 +541,97 @@ export const pageRouter = router({
}
return permalinkTree
}),

createIndexPage: protectedProcedure
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note - this mimics how on-call isoengineer currently add an index page manually

Copy link
Contributor

@seaerchin seaerchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some clarifications but overall ok, no issues w approach. happy to approve later on

@adriangohjw adriangohjw enabled auto-merge (squash) February 3, 2025 05:07
@adriangohjw adriangohjw disabled auto-merge February 3, 2025 05:15
@adriangohjw adriangohjw merged commit 2397089 into main Feb 3, 2025
17 checks passed
@adriangohjw adriangohjw deleted the feat/admin-create-index-page-temp-workabout branch February 3, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants