Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add gb #1049

Merged
merged 6 commits into from
Feb 3, 2025
Merged

chore: add gb #1049

merged 6 commits into from
Feb 3, 2025

Conversation

seaerchin
Copy link
Contributor

Problem

We want to gate the dropdown for collections to hfpg only (siteId = 29)

Solution

  1. add growthbook feature key
  2. retrieve key at runtime
  3. depending on feature key, render either text control (old) or the dropdown (new)

Tests

For staging

  1. go to site id = 7
  2. create a collection
  3. create a page in the collection
  4. the article category should be a dropdown
  5. go to any other site id
  6. repeat steps 2-3
  7. the article category should be a free text field

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 27, 2025

Datadog Report

Branch report: feat/grwothbook-dropdown
Commit report: b61fa7c
Test service: isomer-studio

✅ 0 Failed, 264 Passed, 36 Skipped, 45.58s Total Time
➡️ Test Sessions change in coverage: 1 no change

Copy link
Contributor

@adriangohjw adriangohjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually why not just add this flag in the config column in Site? might be easier for testing too

Copy link
Contributor Author

seaerchin commented Feb 3, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@seaerchin seaerchin changed the base branch from feat/dropdown-collections to graphite-base/1049 February 3, 2025 04:59
@karrui karrui changed the base branch from graphite-base/1049 to main February 3, 2025 05:00
Copy link

graphite-app bot commented Feb 3, 2025

Merge activity

  • Feb 3, 12:00 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@seaerchin seaerchin force-pushed the feat/grwothbook-dropdown branch from ac0a17e to e2d2c69 Compare February 3, 2025 05:01
@seaerchin seaerchin enabled auto-merge (squash) February 3, 2025 05:01
@seaerchin seaerchin merged commit 82f8fed into main Feb 3, 2025
16 of 17 checks passed
@seaerchin seaerchin deleted the feat/grwothbook-dropdown branch February 3, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants