-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce temporary admin mode for site config #1033
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 266 Passed, 36 Skipped, 48.73s Total Time |
ba63312
to
75b5952
Compare
75b5952
to
253b257
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor issue - not too sure what the useEffect
is doing! i think because this affects end user sites (and the site wide config), we might want to sanitise the json object to make sure it's valid (cos we're just parsing to make sure it's valid json, but not that the jsonobject matches what we expect - eg: {siteNavItems: [...]}
vs {siteNavItem: [...]}
but no actionable re: the second point of matching - onlyi want to make sure the useEffect
isn't sussy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly lgtm - i think blind spots for me are the useEffect
, which is actually pretty confusing
the router method can be updated but not a real blocker, given that it's narrowly used and easy to infer from context
Problem
Ops load on engineers is quite high for editing the site config, navbar and footer.
Solution
Breaking Changes
Features:
/admin
route for Isomer Admins to directly modify the site's config, theme, navbar and footer items.Before & After Screenshots
View for Isomer Admins:
View for unauthorised users:
Tests
/admin
to the URL and navigate to the page.