Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in CIS JSON schema #2

Open
jerstlouis opened this issue Nov 4, 2020 · 6 comments
Open

Issues in CIS JSON schema #2

jerstlouis opened this issue Nov 4, 2020 · 6 comments
Assignees

Comments

@jerstlouis
Copy link
Member

In http://schemas.opengis.net/cis/1.1/json/coverage-schema.json

  • gridLimits property specifies that type is required, but type is not listed in the properties
  • In rangeType there is a "description": "quantiy", typo (quantity)

Other issues? Is this schema validated?

@nmtoken
Copy link

nmtoken commented Nov 4, 2020

According to https://www.jsonschemavalidator.net/ http://schemas.opengis.net/cis/1.1/json/coverage-schema.json is valid against the cited schema "$schema": "http://json-schema.org/draft-04/schema#"

I'm not sure how you might otherwise validate it.

@jerstlouis
Copy link
Member Author

jerstlouis commented Nov 4, 2020

Thank you @nmtoken for testing/confirming this. I tried two other validators and they also all seem to validate.

It's odd that it doesn't check whether a required property actually exists.
Maybe it's by design to allow it to be anything as an additional property?
It's missing something like:

   "type": { "enum": [ "GridLimitsType" ] },

@jerstlouis jerstlouis transferred this issue from opengeospatial/ogcapi-coverages Feb 24, 2021
@jerstlouis
Copy link
Member Author

jerstlouis commented Feb 24, 2021

2021-02-24 SWG:
[X] Add schemas to standard/schemas/
[X] Test generating a build matching the current standard
[X ] Make a release to baseline the existing 1.1 standard.
[ ] Address these issues.
[ ] Get new Revision number for the document corrigendum

@jerstlouis
Copy link
Member Author

2021-04-21 SWG: Chuck will test generating a matching build and baseline a 1.1 version.

@cmheazel
Copy link
Contributor

PDF and HTML generated using Asciidoctor can be found in the /standard directory
Do we want a Metanorma build as well?

jerstlouis added a commit to jerstlouis/coverage-implementation-schema that referenced this issue Apr 28, 2021
…efinition for gridLimits (was required); Changed tabs to spaces (opengeospatial#2)
jerstlouis added a commit that referenced this issue May 5, 2021
…efinition for gridLimits (was required); Changed tabs to spaces (#2)
@jerstlouis
Copy link
Member Author

@cmheazel A better way to baseline versions and not clutter the git history and avoid enlarging the repository size would be to use GitHub releases instead, and upload the HTML and PDF documents as assets for those particular releases.

We could have different assets for each release: HTML, PDF, ZIPped / .tar.gz repository with the .adoc's.

I suggest we use this approach consistently across OGC specification repositories. @ghobona @gbuehler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants