refactor(ContributionAssistant): Add support for new Not A Price option on canvas #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
reviewed
Feb 3, 2025
| @@ -429,6 +429,7 @@ | |||
| "PriceTagWithPrice": "Price tag with a price", | |||
| "PriceTagTruncated": "Price tag marked as truncated", | |||
| "PriceTagUnreadable": "Price tag marked as unreadable", | |||
| "PriceTagNotAPrice": "Price tag marked as not a price", | |||
There was a problem hiding this comment.
wondering if we should repeat "Price tag" everywhere, or have a shorter version ?
There was a problem hiding this comment.
I was wondering the same and almost removed it.
But I wasn't sure if "without a price" was understandable since there is no verb. ("Marked as unreadable" would be ok)
raphodn
reviewed
Feb 3, 2025
| @@ -29,15 +29,15 @@ | |||
| </v-btn> | |||
| </template> | |||
| <v-list> | |||
| <v-list-item :slim="true" prepend-icon="mdi-eye-off-outline" @click="removePriceTag(2)"> | |||
| <v-list-item :slim="true" prepend-icon="mdi-eye-off-outline" @click="removePriceTag(constants.PRICE_TAG_STATUS_UNREADABLE)"> | |||
There was a problem hiding this comment.
didn't know you could call constants in the template like this 👀
There was a problem hiding this comment.
Now that you mention it, it does seem a bit odd. Let's hope there are no side effects
There was a problem hiding this comment.
ok i think it doesn't work, reverting
raphodn
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot