Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(CurrentChallenge): simplify the url to /challenge. Add to the sidebar #1325

Merged
merged 4 commits into from
Jan 25, 2025

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Jan 25, 2025

What

  • move the challenge page to /challenge (instead of /experiments/challenge)
  • add a redirect for users who have the old url
  • add the Challenge in the sidebar
  • small change on the page title (remove the title, breadcrumb is already there)

Screenshot

Before After
image image

@@ -37,14 +37,16 @@ const routes = [
{ path: '/users', name: 'users', component: () => import('./views/UserList.vue'), meta: { title: 'TopContributors', icon: 'mdi-account-star-outline', breadcrumbs: [{title: 'TopContributors', disabled: true }] }},
{ path: '/users/:username', name: 'user-detail', component: () => import('./views/UserDetail.vue'), meta: { title: 'User detail' }},
{ path: '/users/:username/proofs', name: 'user-proofs', component: () => import('./views/UserProofList.vue'), meta: { title: 'User proofs', breadcrumbs: [{title: 'Users', disabled: false, to: '/users' }, {title: 'Username', disabled: false, to: '/users/:username' }, {title: 'Proofs', disabled: true }] }},
{ path: '/community', name: 'community', component: () => import('./views/Community.vue'), meta: { title: 'Community', icon: 'mdi-account-group', drawerMenu: true, breadcrumbs: [{title: 'Community', disabled: true }] }},
{ path: '/reuses', name: 'reuses', component: () => import('./views/Reuses.vue'), meta: { title: 'Reuses', icon: 'mdi-account-group', drawerMenu: false, breadcrumbs: [{title: 'Reuses', disabled: true }] }},
{ path: '/challenge', name: 'challenge-current', component: () => import('./views/CurrentChallenge.vue'), meta: { title: 'Challenge', icon: 'mdi-trophy-variant', drawerMenu: true, breadcrumbs: [{title: 'CommunityChallenge', disabled: true }] }},
Copy link
Member Author

@raphodn raphodn Jan 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will most likely be replaced in the future by a Challenges page

@raphodn raphodn merged commit 9a9c3fb into master Jan 25, 2025
7 of 8 checks passed
@raphodn raphodn deleted the raphodn/challenge-url-simple branch January 25, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant