refactor(ContributionAssistant): Full integration with price tag data #1166
Conversation
src/views/ContributionAssistant.vue
Outdated
| @@ -209,84 +209,133 @@ export default { | |||
| // Summary tab should be enabled when there are product prices to be added and the add prices process is either running or done | |||
| const enableSummaryTab = this.productPriceForms.length && (this.addPricesLoading || this.allDone) | |||
| return !enableSummaryTab | |||
| }, | |||
| proofsIdsFromQueryParam() { | |||
| return JSON.parse(this.$router.currentRoute.value.query.proofs) | |||
There was a problem hiding this comment.
could we use proof_ids=id1,id2 instead of proofs=[id1,id2] ?
- rename proofs to proof_ids
- use comma-seperated values
why ? to be more html/API-compliant (well i'm not sure there's hard rules, but arrays in url feels wrong ^^)
example of comma-seperated usage https://search.openfoodfacts.org/docs#/default/search_get_search_get
There was a problem hiding this comment.
an alternative could also be proof_id=id1&next_proof_id=id2
There was a problem hiding this comment.
Sure, I spent a bit of time looking for a standardized way of passing arrays in url params. It's quite surprising that there are none. I went with this one for ease of use using JSON, but I do not like it either 😅
There was a problem hiding this comment.
proof_ids=id1,id2 has my preference, we already use it for product lists in ProductOpener
raphodn
force-pushed
the
ttalex/contribution-assistant-full-pricetag-integration
branch
from
580b837 to
e4d8c41
Compare
raphodn
deleted the
ttalex/contribution-assistant-full-pricetag-integration
branch
…roofs without prices. ref #1166
…roofs without prices (fix). ref #1166
…ly ready proofs without prices. ref #1166
…ly ready proofs owned. ref #1166
What
/experiments/contribution-assistant?proofs=[1512,1513]Demo
Example, starting from a not yet implemented multiple proof upload CTA
https://github.com/user-attachments/assets/517d535f-8283-42f3-957d-94338af3d4c3
Another example, showing how the assistant can be used to add price tags manually (the price validator assistant is used to show an increasing number of price tags, before and after)
https://github.com/user-attachments/assets/14a20851-e269-44fc-b5dd-c6278c7ef726
Note that currently, it only supports adding new price tags, and does not handle removing them.