Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect decode404 flag and decode 404 response body #1012

Merged
merged 4 commits into from
Jul 21, 2019

Conversation

dharmeshjogadia
Copy link
Contributor

Fix the following decoder to decode 404 response body

  • GsonDecoder

  • JacksonJaxbJsonDecoder

  • JacksonDecoder

  • JacksonIteratorDecoder

  • JAXBDecoder

  • SAXDecoder

Fixes #809

@kdavisk6
Copy link
Member

@dharmeshjogadia

Thank you for this PR, as you can see, there are number of issues. I suggest that you make sure that you are using the most recent version of master in your fork. Please either update your fork or rebase against master before continuing.

@kdavisk6 kdavisk6 added the feedback provided Feedback has been provided to the author label Jul 19, 2019
@dharmeshjogadia
Copy link
Contributor Author

Hey @kdavisk6
I have updated the PR against the master and fixes the test as well.

@ugrepel
Copy link

ugrepel commented Oct 19, 2021

Ehhh... after this fix, 404 is only processed into a null response if there is no body. If the 404 response does have a body, e.g. a typical HTML 404 page, or an application specific response which just happens not to be compatible to the expected type, then the result, in case of JaxbDecoder (others will be similar) is a DecodeException.

I would expect a null response, at least if the decode404 flag is set (which, in general, is ignored by the decoders affected by this PR).

velo pushed a commit that referenced this pull request Oct 7, 2024
* decode 404 response body

* fix SOAPCodecTest
velo pushed a commit that referenced this pull request Oct 8, 2024
* decode 404 response body

* fix SOAPCodecTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided Feedback has been provided to the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JacksonDecoder probably ignores decode404 flag
4 participants