This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Optional ethcore features should be enabled by default #9103
Labels
B9-blocker 🚧
This pull request blocks the next release from happening. Use only in extreme cases.
F2-bug 🐞
The client fails to follow expected behavior.
M4-core ⛓
Core client code / Rust.
P5-sometimesoon 🌲
Issue is worth doing soon.
Milestone
Recently some parts for ethcore and ethcore-miner were made optional: see #9020
However, we import
ethcore
andethcore-miner
crate from multiple places, an all of those places should specify the required features. It is however easly forgotten.We should make the features
default
, and other crates that don't require them should just include the crate withno-default-features
.Also using the features if they are disabled should trigger an error. Currently 2.0 and 2.1 just silently fail to work correctly. Seems that
work-notify
,price-info
andstratum
are just broken currently.The text was updated successfully, but these errors were encountered: