Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Auto-updater upgradability verification #8178

Closed
tomusdrw opened this issue Mar 21, 2018 · 6 comments · Fixed by #8787
Closed

Auto-updater upgradability verification #8178

tomusdrw opened this issue Mar 21, 2018 · 6 comments · Fixed by #8787
Assignees
Labels
F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Milestone

Comments

@tomusdrw
Copy link
Collaborator

When updating a major release (say 1.8-stable -> 1.9-stable) there might be breaking changes with CLI flags or config entries.
Auto-updater should first test if new binary will be able to execute with the same parameters and only update if it's successful. Otherwise it should print a warning message every now and then.

@tomusdrw tomusdrw added F8-enhancement 🎊 An additional feature request. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. M4-core ⛓ Core client code / Rust. labels Mar 21, 2018
@tomusdrw tomusdrw changed the title Auto-updater upgradeability verification Auto-updater upgradability verification Mar 21, 2018
@5chdn 5chdn added the P5-sometimesoon 🌲 Issue is worth doing soon. label Mar 26, 2018
@5chdn 5chdn added this to the 1.11 milestone Mar 26, 2018
@niklasad1 niklasad1 self-assigned this Mar 26, 2018
@niklasad1
Copy link
Collaborator

I will wait with this one until #7272 is merged seem to be significant changes

@5chdn 5chdn modified the milestones: 1.11, 1.12 Apr 24, 2018
@folsen
Copy link
Contributor

folsen commented May 21, 2018

@niklasad1 @andresilva Is this now addressable, do you still intend to take this Niklas or do you want to unassign yourself?

@andresilva
Copy link
Contributor

Yes, I don't expect any more changes on the auto-updater for now so I think this is addressable.

@niklasad1
Copy link
Collaborator

I’m on it, will fix it soon has taken some time to understand to updater code though!

@andresilva
Copy link
Contributor

You should also have a look at parity/main.rs, I think most changes will have to be done there (that code is a bit hairy right now). The updater downloads new binaries to io.parity.ethereum-updates and updates a file named latest in that directory to point to the latest version. By default, when parity starts it checks this file and launches that binary instead.

@LYY
Copy link

LYY commented Jun 6, 2018

I'm using parity on centos 7. Today parity had auto-updated, but restarted failed. It seems like download general linux version, not centos version.

I deleted error logs, it looks like this:

./parity: /lib64/libstdc++.so.6: version `CXXABI_1.3.8' not found (required by ./parity)
./parity: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by ./parity)
./parity: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by ./parity)
./parity: /lib64/libc.so.6: version `GLIBC_2.18' not found (required by ./parity)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants