Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Node::from_str() reports errors incorrectly #6972

Closed
0x7CFE opened this issue Nov 2, 2017 · 0 comments
Closed

Node::from_str() reports errors incorrectly #6972

0x7CFE opened this issue Nov 2, 2017 · 0 comments
Assignees
@dvdplm
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Milestone
2.0 Ethereum

Comments

@0x7CFE
Copy link
Contributor

0x7CFE commented Nov 2, 2017

Impl FromStr for Node and NodeEndpoint return NetworkError::AddressResolve even on incorrectly formatted addresses, like foo, enode://foo@bar and even on an empty string.

Issue exists on 713bba0 and earlier.
@0x7CFE 0x7CFE added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. labels Nov 2, 2017
@0x7CFE 0x7CFE mentioned this issue Nov 2, 2017
Merged
2 tasks
@5chdn 5chdn added this to the 1.9 milestone Nov 2, 2017
@5chdn 5chdn added the P5-sometimesoon 🌲 Issue is worth doing soon. label Nov 2, 2017
@5chdn 5chdn modified the milestones: 1.9, 1.10 Jan 5, 2018
@5chdn 5chdn modified the milestones: 1.10, 1.11 Jan 23, 2018
@5chdn 5chdn modified the milestones: 1.11, 1.12 Mar 1, 2018
@debris debris added the Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. label Apr 17, 2018
@5chdn 5chdn modified the milestones: 1.12, 1.13 Apr 24, 2018
@dvdplm dvdplm self-assigned this May 4, 2018
@dvdplm dvdplm mentioned this issue May 7, 2018
Merged
@5chdn 5chdn modified the milestones: 1.13, 1.12 May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dvdplm dvdplm

Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Milestone
2.0 Ethereum
Development

No branches or pull requests
4 participants
@dvdplm @debris @0x7CFE @5chdn