Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Deprecate separate Signer interface #2080

Closed
tomusdrw opened this issue Sep 13, 2016 · 0 comments
Closed

Deprecate separate Signer interface #2080

tomusdrw opened this issue Sep 13, 2016 · 0 comments
Assignees
@tomusdrw
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P9-somedaymaybe 🌞 Issue might be worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.

Comments

@tomusdrw
Copy link
Collaborator

After we have:
#884 (which will expose WebSockets connection anyway)

and
#1235 (per-request for HTTP and per-session for WS)

and
few changes in jsonrpc-core to support permissioned methods

Separate API for Signer will not be needed.
@tomusdrw tomusdrw added F6-refactor 📚 Code needs refactoring. P9-somedaymaybe 🌞 Issue might be worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. labels Sep 13, 2016
@tomusdrw tomusdrw changed the title Deprecate Separate Signer interface Deprecate separate Signer interface Sep 13, 2016
@gavofyork gavofyork added M4-core ⛓ Core client code / Rust. and removed M4-core ⛓ Core client code / Rust. labels Sep 20, 2016
@tomusdrw tomusdrw self-assigned this May 9, 2017
@tomusdrw tomusdrw mentioned this issue May 9, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tomusdrw tomusdrw

Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P9-somedaymaybe 🌞 Issue might be worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gavofyork @tomusdrw