Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Remove panickers in Trie module #1397

Closed
rphmeier opened this issue Jun 22, 2016 · 4 comments
Closed

Remove panickers in Trie module #1397

rphmeier opened this issue Jun 22, 2016 · 4 comments
Assignees
@rphmeier
Labels
F6-refactor 📚 Code needs refactoring. Z7-duplicate 🖨 Issue is a duplicate. Closer should comment with a link to the duplicate.
Milestone
1.3 Acuity

Comments

@rphmeier
Copy link
Contributor

rphmeier commented Jun 22, 2016 •
edited
Loading

failed DB lookups shouldn't cause panics (immediately)

related to, but does not solve #1395
@rphmeier rphmeier added the F6-refactor 📚 Code needs refactoring. label Jun 22, 2016
@rphmeier rphmeier self-assigned this Jun 22, 2016
@rphmeier
Copy link
Contributor Author

I will work on landing this shortly after the in-memory trie optimization

@AlbieC
Copy link

AlbieC commented Jun 23, 2016

I also think it's related to #1395 because Parity panicks and stops/exists now even without any miner connected (or trying to connect) to it. Also possibly memory related as when I close Firefox, at least Parity starts searching and then panicks and exists, as opposed to immediately if any other apps is running as well.

@gavofyork gavofyork modified the milestone: 1.3 Acuity Jul 7, 2016
@gavofyork gavofyork modified the milestones: 1.3 Acuity, 1.4 Civility Jul 30, 2016
@rphmeier
Copy link
Contributor Author

mostly addressed by #1776

@gavofyork gavofyork modified the milestones: 1.4 Civility, 1.3 Acuity Jul 30, 2016
@gavofyork
Copy link
Contributor

part of #1026

@gavofyork gavofyork added the Z7-duplicate 🖨 Issue is a duplicate. Closer should comment with a link to the duplicate. label Aug 1, 2016
@dzh dzh mentioned this issue May 20, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rphmeier rphmeier

Labels
F6-refactor 📚 Code needs refactoring. Z7-duplicate 🖨 Issue is a duplicate. Closer should comment with a link to the duplicate.
Projects
None yet
Milestone
1.3 Acuity
Development

No branches or pull requests
3 participants
@gavofyork @rphmeier @AlbieC