-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frr: fix latest CVEs #688
Closed
KanjiMonster
wants to merge
3
commits into
openembedded:kirkstone
from
bisdn:jogo_kirkstone_frr_fixes
Closed
frr: fix latest CVEs #688
KanjiMonster
wants to merge
3
commits into
openembedded:kirkstone
from
bisdn:jogo_kirkstone_frr_fixes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a security fix from the stable/8.2 branch for two CVEs for the same vulneratiblity: CVE-2022-36440: A reachable assertion was found in Frrouting frr-bgpd 8.3.0 in the peek_for_as4_capability function. Attackers can maliciously construct BGP open packets and send them to BGP peers running frr-bgpd, resulting in DoS. CVE-2022-40302: An issue was discovered in bgpd in FRRouting (FRR) through 8.4. By crafting a BGP OPEN message with an option of type 0xff (Extended Length from RFC 9072), attackers may cause a denial of service (assertion failure and daemon restart, or out-of-bounds read). This is possible because of inconsistent boundary checks that do not account for reading 3 bytes (instead of 2) in this 0xff case. Reference: https://nvd.nist.gov/vuln/detail/CVE-2022-36440 https://nvd.nist.gov/vuln/detail/CVE-2022-40302 https://cyberriskleaders.com/new-vulnerabilities-disclosed-in-frrouting-software/ FRRouting/frr#13202 Patch from: FRRouting/frr@02a0e45 Signed-off-by: Jonas Gorski <[email protected]>
Add a security fix from the stable/8.2 branch: CVE-2022-40318: An issue was discovered in bgpd in FRRouting (FRR) through 8.4. By crafting a BGP OPEN message with an option of type 0xff (Extended Length from RFC 9072), attackers may cause a denial of service (assertion failure and daemon restart, or out-of-bounds read). This is possible because of inconsistent boundary checks that do not account for reading 3 bytes (instead of 2) in this 0xff case. NOTE: this behavior occurs in bgp_open_option_parse in the bgp_open.c file, a different location (with a different attack vector) relative to CVE-2022-40302. Reference: https://nvd.nist.gov/vuln/detail/CVE-2022-40318 https://cyberriskleaders.com/new-vulnerabilities-disclosed-in-frrouting-software/ Patch from: FRRouting/frr@72088b0 Signed-off-by: Jonas Gorski <[email protected]>
Add a security fix cherry-picked from master: CVE-2022-40318: An out-of-bounds read exists in the BGP daemon of FRRouting FRR through 8.4. When sending a malformed BGP OPEN message that ends with the option length octet (or the option length word, in case of an extended OPEN message), the FRR code reads of out of the bounds of the packet, throwing a SIGABRT signal and exiting. This results in a bgpd daemon restart, causing a Denial-of-Service condition. Reference: https://nvd.nist.gov/vuln/detail/CVE-2022-43681 https://cyberriskleaders.com/new-vulnerabilities-disclosed-in-frrouting-software/ Patch from: FRRouting/frr@766eec1 Signed-off-by: Jonas Gorski <[email protected]>
Update for langdale is #689, master and mickledore are unaffected as these issues were already fixed in the original 8.4 release. |
Is there anything I can do to help getting this applied? Both PRs were build tested and shortly runtested via a simple bgp setup across 4 machines. |
I grabbed these this morning. |
Great, thanks for the update! |
KanjiMonster
added a commit
to bisdn/meta-bisdn-linux
that referenced
this pull request
Jun 2, 2023
Fix frr CVEs CVE-2022-36440, CVE-2022-40318, CVE-2022-43681 locally until the fixes get merged at OE upstream. Reference: openembedded/meta-openembedded#688 Signed-off-by: Jonas Gorski <[email protected]>
jklare
pushed a commit
to bisdn/meta-bisdn-linux
that referenced
this pull request
Jun 2, 2023
Fix frr CVEs CVE-2022-36440, CVE-2022-40318, CVE-2022-43681 locally until the fixes get merged at OE upstream. Reference: openembedded/meta-openembedded#688 Signed-off-by: Jonas Gorski <[email protected]>
applied as of 3670781 on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add/backport patches for the latest round of CVEs:
First two taken from stable/8.2, last one cherry-picked from master.
Reference:
https://cyberriskleaders.com/new-vulnerabilities-disclosed-in-frrouting-software/