-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replaced confusing exam messages with some more suitable ones #158
fix: replaced confusing exam messages with some more suitable ones #158
Conversation
Thanks for the pull request, @Anas12091101! This repository is currently unmaintained. 🔘 Find a technical reviewerTo get help with finding a technical reviewer, reach out to the community contributions project manager for this PR:
Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
abcc171
to
58a5e96
Compare
58a5e96
to
530c335
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these text changes. They are now a better reflection of the actual process for proctored exams.
I'm not familiar with this repo. Is there a version number that needs to be updated and/or a changelog?
The version number in package.json hasn't been updated since v1.14.0. |
@@ -6,8 +6,8 @@ const VerifiedProctoredExamInstructions = () => ( | |||
<h3 className="h3" data-testid="proctored-exam-instructions-title"> | |||
<FormattedMessage | |||
id="exam.VerifiedProctoredExamInstructions.title" | |||
defaultMessage={'Your proctoring session was reviewed successfully. ' | |||
+ 'A final grade will be available soon.'} | |||
defaultMessage={'Exams are being reviewed and ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to better understand the change from Your proctoring session was reviewed successfully
to Exams are being reviewed
. These instructions are shown to the learner when a proctored exam attempt has already been reviewed and the attempt is in the verified
state. Why are we communicating that the attempt is in the process of being reviewed instead?
I see that Peter commented that this is a better reflection of the actual proctoring process. Can you elaborate on why that is?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, I completely missed that the main message we wanted to update, Go to your progress page to view your exam grade
, was already changed in this commit. I’m sorry for the oversight.
@pdpinch, do we also need to apply this change(Exams are being reviewed
) for the verified state? We already had a discussion on this topic here: #63 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. What you have here is good enough:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 94.31% 94.31%
=======================================
Files 68 68
Lines 1090 1090
Branches 301 301
=======================================
Hits 1028 1028
Misses 57 57
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What are the relevant tickets?
https://github.com/mitodl/hq/issues/708 , https://github.com/mitodl/hq/issues/720
Description (What does it do?)
This PR updates the confusing exam instruction messages with better messages to avoid confusion among the students.
How can this be tested?
submit
from admin (admin/edx_proctoring/proctoredexamstudentattempt/)verified
from the django admin. Reload the page. The page would look like this: