Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replaced confusing exam messages with some more suitable ones #158

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

Anas12091101
Copy link
Contributor

@Anas12091101 Anas12091101 commented Jan 29, 2025

What are the relevant tickets?

https://github.com/mitodl/hq/issues/708 , https://github.com/mitodl/hq/issues/720

Description (What does it do?)

This PR updates the confusing exam instruction messages with better messages to avoid confusion among the students.

How can this be tested?

  • Create a proctor exams using instructions here
  • Setup mockprock and this edx-proctoring branch in your local edX setup using instructions here
  • Enroll a test user in the course in the verified mode.
  • Start the exam. You can directly change the status to submit from admin (admin/edx_proctoring/proctoredexamstudentattempt/)
  • Visit the problem after changing the status. You should see this page:
Screenshot 2025-01-29 at 9 05 33 PM
  • Now change the status to verified from the django admin. Reload the page. The page would look like this:
Screenshot 2025-01-29 at 8 52 39 PM

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 29, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 29, 2025

Thanks for the pull request, @Anas12091101!

This repository is currently unmaintained.

🔘 Find a technical reviewer To get help with finding a technical reviewer, reach out to the community contributions project manager for this PR:
  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your project manager.
  2. Find their GitHub handle here.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Anas12091101 Anas12091101 force-pushed the anas/update-exam-instruction-msgs branch from abcc171 to 58a5e96 Compare January 29, 2025 15:59
@Anas12091101 Anas12091101 force-pushed the anas/update-exam-instruction-msgs branch from 58a5e96 to 530c335 Compare January 29, 2025 16:04
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 29, 2025
Copy link

@pdpinch pdpinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these text changes. They are now a better reflection of the actual process for proctored exams.

I'm not familiar with this repo. Is there a version number that needs to be updated and/or a changelog?

@Anas12091101
Copy link
Contributor Author

Is there a version number that needs to be updated and/or a changelog?

The version number in package.json hasn't been updated since v1.14.0.

@@ -6,8 +6,8 @@ const VerifiedProctoredExamInstructions = () => (
<h3 className="h3" data-testid="proctored-exam-instructions-title">
<FormattedMessage
id="exam.VerifiedProctoredExamInstructions.title"
defaultMessage={'Your proctoring session was reviewed successfully. '
+ 'A final grade will be available soon.'}
defaultMessage={'Exams are being reviewed and '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to better understand the change from Your proctoring session was reviewed successfully to Exams are being reviewed. These instructions are shown to the learner when a proctored exam attempt has already been reviewed and the attempt is in the verified state. Why are we communicating that the attempt is in the process of being reviewed instead?

I see that Peter commented that this is a better reflection of the actual proctoring process. Can you elaborate on why that is?

Thanks!

Copy link
Contributor Author

@Anas12091101 Anas12091101 Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I completely missed that the main message we wanted to update, Go to your progress page to view your exam grade, was already changed in this commit. I’m sorry for the oversight.

@pdpinch, do we also need to apply this change(Exams are being reviewed) for the verified state? We already had a discussion on this topic here: #63 (comment).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.31%. Comparing base (0de890c) to head (530c335).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files          68       68           
  Lines        1090     1090           
  Branches      301      301           
=======================================
  Hits         1028     1028           
  Misses         57       57           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 7, 2025
Copy link
Contributor

@michaelroytman michaelroytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaelroytman michaelroytman merged commit 4878aef into openedx:main Feb 12, 2025
1 check passed
Copy link

🎉 This PR is included in version 3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants