fix: Height in Advanced Editor [FC-0076]

[ChrisChV]

Description

• Updates the height of the Advanced Editor.
• Which edX user roles will this change impact? "Course Author"

Supporting information

• Related to fix: Advanced editor styles [FC-0076] edx-platform#36221
• Internal ticket: FAL-4040

Testing instructions

• Go to a course. Go to Advanced settings
• Add the following in Advanced module list:

[
    "done",
    "google-calendar",
    "google-document",
    "pdf",
]

• Install the PDF plugging
• Create and copy a completion block
• Go to the library home of a library. Paste the block.
• Open the Editor. Verify the style, and verify that the text does not overlap with the close button.
• Also verify that the editor has a good size.
• Also verify that the Save and Cancel buttons are on the right side.
• Also verify that the buttons are at the bottom of the modal.
• On the course unit, create and copy a PDF block.
• Go to the library and paste the block.
• Open the Editor. Verify the style of the Save and Cancel buttons.
• Also verify that the Save and Cancel buttons are on the right side.
• Also verify that the buttons are at the bottom of the modal.
• On the course unit, create and copy a Google Document block.
• Go to the library and paste the block.
• Open the Editor. Verify that the Save and Cancel buttons are on the right side and the bottom of the modal.

Other information

N/A

[openedx-webhooks]

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.24%. Comparing base (31f39cb) to head (bfc12d1).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1649   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files        1100     1101    +1     
  Lines       21803    21860   +57     
  Branches     4632     4644   +12     
=======================================
+ Hits        20330    20384   +54     
- Misses       1408     1411    +3     
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pomegranited]

👍 to making the editor modal larger -- that makes it easier to edit the most commonly-used XBlocks, though it's a bit weird for the ones tested here, as they don't have enough fields to fill the full 80vh.

e.g. Google Document:

PDF:

Completion:

• I tested this using the PR test instructions.
• I read through the code
• I checked for accessibility issues N/A
• Includes documentation N/A
• User-facing strings are extracted for translation N/A

[pomegranited]

nit: I think this would be clearer if you moved the line from below up here and used its value:

Suggested change

	const defaultiFrameHeight = view === 'studio_view' ? 80 : 50;
	const xblockView = view ?? 'student_view';
	const defaultiFrameHeight = xblockView === 'studio_view' ? 80 : 50;

[ChrisChV]

Fixed bfc12d1