Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add PII annotations #543

Closed
wants to merge 4 commits into from

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Nov 25, 2024

Per OEP-30 these annotations should live with the models, just moving them here from the edx-platform safelist.

Per OEP-30 these annotations should live with the models, just moving
them here from the edx-platform safelist.
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.58%. Comparing base (b7c5db6) to head (8bfe405).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #543   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files          32       32           
  Lines        3178     3178           
  Branches      122      122           
=======================================
  Hits         3006     3006           
  Misses        154      154           
  Partials       18       18           
Flag Coverage Δ
unittests 94.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmtcril
Copy link
Contributor Author

bmtcril commented Dec 4, 2024

@BrandonHBodine @jansenk I could use a quick review on this PR, but first do either of you have any idea why this is consistently failing the Pact tests?

@bmtcril
Copy link
Contributor Author

bmtcril commented Feb 18, 2025

Closing this PR to open a new one that's not from my fork. Apparently forks don't have permissions to run the Pact tests.

@bmtcril bmtcril closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant