Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bff handle feedback only criteria #2154

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

nsprenkle
Copy link
Contributor

@nsprenkle nsprenkle commented Jan 3, 2024

TL;DR - Fix BFF handling of feedback-only rubric criteria.

JIRA: AU-1646

Developer Checklist

Testing Instructions

  1. Create an ORA.
  2. Edit the ORA to remove all rubric options from one / all of the rubric criteria.
  3. Save.
  4. Submit a response & progress to end of grading workflow.
  5. Verify nothing breaks.

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f3bd8f1) 94.93% compared to head (29a64fa) 94.92%.

Files Patch % Lines
...ent/xblock/ui_mixins/mfe/assessment_serializers.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2154      +/-   ##
==========================================
- Coverage   94.93%   94.92%   -0.01%     
==========================================
  Files         191      191              
  Lines       20570    20571       +1     
  Branches     1864     1865       +1     
==========================================
  Hits        19528    19528              
  Misses        779      779              
- Partials      263      264       +1     
Flag Coverage Δ
unittests 94.92% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nsprenkle nsprenkle marked this pull request as ready for review January 4, 2024 15:06
@nsprenkle nsprenkle requested a review from a team as a code owner January 4, 2024 15:06
@nsprenkle nsprenkle changed the title Nsprenkle/bff handle feedback only criteria fix: bff handle feedback only criteria Jan 4, 2024
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@nsprenkle nsprenkle merged commit dae4b35 into master Jan 4, 2024
5 of 7 checks passed
@nsprenkle nsprenkle deleted the nsprenkle/bff-handle-feedback-only-criteria branch January 4, 2024 19:02
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
* fix: allow feedback only criteria in assessment

* chore: bump ORA to 6.0.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants