chore: remove disable on assessment out of order #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you need to update a test that's expecting reordered steps to mean that we can't use MFE views |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2153 +/- ##
==========================================
- Coverage 94.92% 94.92% -0.01%
==========================================
Files 191 191
Lines 20571 20559 -12
Branches 1865 1862 -3
==========================================
- Hits 19528 19516 -12
Misses 779 779
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leangseu-edx
force-pushed
the
lk/step-order
branch
from
fd92729 to
892c265
Compare
BryanttV
pushed a commit
to eduNEXT/edx-ora2
that referenced
this pull request
Feb 6, 2024
* chore: remove disable on assessment out of order * chore: update test * chore: update html tag * chore: version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - workflow steps should work even it is out of order
JIRA: https://2u-internal.atlassian.net/browse/AU-1603
NOTE you can only re-arrange self and practice stage. ORA protect us from saving any other order.
Developer Checklist
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora