Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FC-0001: switch from FutureCourseWaffleFlag to CourseWaffleFlag #1855

Merged

Conversation

dyudyunov
Copy link
Contributor

Use the updated CourseWaffleFlag.
FutureCourseWaffleFlag will be removed from the platform.

This is a part of openedx/public-engineering#28

@dyudyunov dyudyunov requested a review from a team as a code owner May 6, 2022 09:29
@openedx-webhooks
Copy link

Thanks for the pull request, @dyudyunov! I've created OSPR-6661 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels May 6, 2022
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1855 (24c7302) into master (ebd41ec) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1855   +/-   ##
=======================================
  Coverage   94.95%   94.95%           
=======================================
  Files         153      153           
  Lines       17014    17014           
  Branches     1875     1875           
=======================================
  Hits        16155    16155           
  Misses        643      643           
  Partials      216      216           
Flag Coverage Δ
unittests 94.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openassessment/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd41ec...24c7302. Read the comment docs.

@natabene
Copy link

natabene commented May 6, 2022

@dyudyunov Thank you for your contribution. Is this ready for our review?

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels May 6, 2022
@dyudyunov dyudyunov changed the title refactor: switch from FutureCourseWaffleFlag to CourseWaffleFlag FC-0001: switch from FutureCourseWaffleFlag to CourseWaffleFlag May 6, 2022
@dyudyunov
Copy link
Contributor Author

@natabene yes

Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll approve/merge/publish once the edx-platform change has gone through. Thank you.

@leangseu-edx leangseu-edx self-requested a review May 10, 2022 15:50
Use the updated CourseWaffleFlag.
FutureCourseWaffleFlag will be removed from the platform.
@dyudyunov dyudyunov force-pushed the switch-to-updated-CourseWaffleFlag branch from ec7e0b7 to 24c7302 Compare May 10, 2022 15:58
@dyudyunov
Copy link
Contributor Author

rebased on master

@mattcarter mattcarter merged commit 8ca9afa into openedx:master May 10, 2022
@openedx-webhooks openedx-webhooks added merged and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels May 10, 2022
@openedx-webhooks
Copy link

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@robrap
Copy link
Contributor

robrap commented May 10, 2022

@mattcarter @jansenk @leangseu-edx: Thanks for the approvals and merge. This PR has a dependency on openedx/edx-platform#30351, which is working its way to Stage now. If the edx-platform change were reverted, this upgrade would break edx-platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants