-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FC-0001: switch from FutureCourseWaffleFlag to CourseWaffleFlag #1855
FC-0001: switch from FutureCourseWaffleFlag to CourseWaffleFlag #1855
Conversation
Thanks for the pull request, @dyudyunov! I've created OSPR-6661 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov Report
@@ Coverage Diff @@
## master #1855 +/- ##
=======================================
Coverage 94.95% 94.95%
=======================================
Files 153 153
Lines 17014 17014
Branches 1875 1875
=======================================
Hits 16155 16155
Misses 643 643
Partials 216 216
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@dyudyunov Thank you for your contribution. Is this ready for our review? |
@natabene yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll approve/merge/publish once the edx-platform change has gone through. Thank you.
Use the updated CourseWaffleFlag. FutureCourseWaffleFlag will be removed from the platform.
ec7e0b7
to
24c7302
Compare
rebased on master |
@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
@mattcarter @jansenk @leangseu-edx: Thanks for the approvals and merge. This PR has a dependency on openedx/edx-platform#30351, which is working its way to Stage now. If the edx-platform change were reverted, this upgrade would break edx-platform. |
Use the updated CourseWaffleFlag.
FutureCourseWaffleFlag will be removed from the platform.
This is a part of openedx/public-engineering#28