Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.3 #3300

Closed
kolyshkin opened this issue Nov 30, 2021 · 3 comments
Closed

Release 1.0.3 #3300

kolyshkin opened this issue Nov 30, 2021 · 3 comments
Assignees
Milestone

Comments

@kolyshkin
Copy link
Contributor

It's time to release 1.0.3.

PRs need to be merged for 1.0.3 are under 1.0.3 milestone.

Changes merged since 1.0.2:

Draft release notes

Bugfixes:
* Fixed inability to start a container with read-write bind mount of a
  read-only fuse host mount (#3292)
* Fixed inability to start when read-only /dev in set in spec (#3277)
* Fixed not removing sub-cgroups upon container delete, when rootless cgroup v2
  is used with older systemd (#3297)
* Fixed returning error from GetStats when hugetlb is unsupported (which causes
  excessive logging for kubernetes) (#3295)
* [CI only] Fixed criu 3.16 compatibility issue (#3282)
* [CI only] Add Go 1.17 to the testing matrix (#3299)

Enhancements: 
* Improved an error message when dbus-user-session is not installed and
  rootless + cgroup2 + systemd are used (#3212)

(Note: I have omitted #3298 from the changelog as it's purely internal)

Notes on backporting

After seeing #3295 (thank you @AkihiroSuda) I realized we're not doing a good job wrt backports. One reason is the tag (backport/1.0-candidate) does not tell anything about whether the work is done or not.

So I renamed it to backport/todo/1.0 and combed through all 24 PRs. For each fo thoser, made sure the backport PR exists, linked to it in description ("1.0 backport: #xxxx), and changed the label from backport/todo/1.0 to backport/done/1.0.

Also found a few PRs were not backported, and opened #3297, #3298, #3299.

I may look into using projects for these.

@kolyshkin kolyshkin added this to the 1.0.3 milestone Dec 1, 2021
@cyphar
Copy link
Member

cyphar commented Dec 4, 2021

backport/todo and backport/done LGTM. The candidate tag was just intended so that we could tell each other whether an open PR was intended to be backported, but having a separate "done" state makes sense. As for using projects, maybe that makes some sense but I suspect it'd only be really useful once we have a lot of things to backport for releases we're maintaining for a while. I haven't played with projects much -- could we create a custom tagging setup where the project state matches the todo+done tags? Or does the project automation only let you do kanban-style automation?

@kolyshkin
Copy link
Contributor Author

I thought it's possible to do some basic "move to project column based on a label" but apparently not (without some third-party webhooks): dear-github/dear-github#364.

As we're not doing a lot of backports, I guess we're fine with these todo/done labels for now.

@cyphar
Copy link
Member

cyphar commented Dec 6, 2021

@cyphar cyphar closed this as completed Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants