Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Add content type header in blob uploads #101

Open
dmcgowan opened this issue Feb 13, 2020 · 3 comments
Open

spec: Add content type header in blob uploads #101

dmcgowan opened this issue Feb 13, 2020 · 3 comments

Comments

@dmcgowan
Copy link
Member

Add the content type header to blob upload endpoints with language about what the value should be. In the case of blobs, the content type should be ignored and this is best represented as using the application/octet-stream Content-Type. Any other types will be ignored by a registry and not be reflected when that blob is pulled.

I don't think a 415 return status is appropriate when application/octet-stream is not used. We should explicitly call that out since ignored != unsupported. Ping @rchincha

@rchincha
Copy link
Contributor

So when pushing Content-Type is just an opaque label. However, not clear from your comment above on what the behavior should be a client pulls with an Accept? If this header not present, then return whatever it was pushed with. But if present and pull(Accept) != pushed(Content-Type), what happens?

@vbatts
Copy link
Member

vbatts commented Jan 28, 2021

Isn't this more clearly laid out in #212 ?
(i'm thinking we can close this current issue)

@jonjohnsonjr
Copy link
Contributor

What does this solve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants