Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the metrics used in the original paper, e.g., CSI, PSD, CPRS? #31

Open
GreenLimeSia opened this issue Jul 18, 2022 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@GreenLimeSia
Copy link

Dear @jacobbieker:
Thanks for your excellent work for DGMR. I have some questions about the metrics used in the original paper. Do you have any plans to add these metrics to the script?

Thanks and best regards.

@GreenLimeSia GreenLimeSia added the enhancement New feature or request label Jul 18, 2022
@jacobbieker
Copy link
Member

Hi, glad you like this work! I hadn't thought about adding the metrics, but probably will at some point either here, or in HuggingFace Evaluate to have it be more general. But also, happy to accept any PRs or anything adding those too!

@GreenLimeSia
Copy link
Author

Thanks for your reply. I will try to do it.
Thanks and best regards.

@jacobbieker
Copy link
Member

Thanks! Looking forward to seeing your work, and if I can help in anyway, just shout!

@peterdudfield
Copy link
Contributor

@all-contributors please add @GreenLimeSia for question

@allcontributors
Copy link
Contributor

@peterdudfield

I've put up a pull request to add @GreenLimeSia! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants