Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the regex in from_semconv_specs with the https://docs.rs/semver/latest/semver/ crate. #579

Open
lquerel opened this issue Jan 30, 2025 · 0 comments
Open

Replace the regex in from_semconv_specs with the https://docs.rs/semver/latest/semver/ crate. #579

lquerel opened this issue Jan 30, 2025 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lquerel
Copy link
Contributor

lquerel commented Jan 30, 2025

In the weaver_semconv/src/registry.rs method from_semconv_specs (see todo), we should use: https://docs.rs/semver/latest/semver/ and URL parser that can give us the last element of the path to send to the parser.

See this PR comment: #400
@lquerel lquerel added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 30, 2025
@lquerel lquerel mentioned this issue Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
OTel Weaver Project
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lquerel