Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change requirement level of network.transport in HTTP semconv #389

Closed
trask opened this issue Oct 12, 2023 · 1 comment · Fixed by #402
Closed

Change requirement level of network.transport in HTTP semconv #389

trask opened this issue Oct 12, 2023 · 1 comment · Fixed by #402
Assignees

Comments

@trask
Copy link
Member

trask commented Oct 12, 2023

Tracking issue for @lmolkova's #373 (comment):

One thing we can consider is to require network.transport presence for HTTP/3 if it's known for sure

I.e. change "If not default (tcp for HTTP/1.1 and HTTP/2, udp for HTTP/3)."

to

"If not default (tcp for HTTP/1.1 and HTTP/2). MUST be set for HTTP/3 if it is known"

This way, a lack of protocol would mean a lack of information (and not default value). We should still be able to change the condition in the future if we'd have reliable ways to determine the protocol.

currently:

- ref: network.transport
requirement_level:
conditionally_required: If not default (`tcp` for `HTTP/1.1` and `HTTP/2`, `udp` for `HTTP/3`).

@trask
Copy link
Member Author

trask commented Oct 13, 2023

follow-up from @lmolkova:

so HTTP/3 is always over QUIC which is always over UPD. QUIC is also a transport protocol and has TCP/2 nickname.

so it seems to be precise, we'd rather set network.transport to QUIC rather than to UDP.
it seems we never really need transport for HTTP as long as we set protocol version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants