Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

Prometheus Service Discovery Configuration Interception #32

Closed
Aneurysm9 opened this issue Apr 8, 2021 · 4 comments
Closed

Prometheus Service Discovery Configuration Interception #32

Aneurysm9 opened this issue Apr 8, 2021 · 4 comments
Assignees
Labels
phase2 phase2 tasks prom-receiver Prometheus receiver tasks

Comments

@Aneurysm9
Copy link
Member

To enable the OTel Operator to perform Prometheus scrape target identification for a set of Collector instances in support of #6 we need to be able to identify and extract all *_sd_config and relabel_config entries in each scrape_config entry in the Prometheus receiver configuration. All *_sd_config entries should be replaced by a single file_sd_config entry referencing a file that can be updated by the Collector Prometheus receiver's target update mechanism (to be constructed) prior to the configuration being used to create a ConfigMap for Collector instances. The extracted configurations should be preserved for use by the target discovery and distribution mechanism to be built in the Operator.

This issue should be used to track the design of the SD configuration interception mechanism in the OTel Operator and to aggregate any other issues or PRs created during implementation.

@alolita alolita added phase1 phase1 tasks prom-receiver Prometheus receiver tasks labels Apr 8, 2021
@alolita alolita added phase2 phase2 tasks and removed prom-receiver Prometheus receiver tasks phase1 phase1 tasks labels May 26, 2021
@alolita
Copy link
Member

alolita commented May 26, 2021

This is a change that needs to be made in the Operator after #33 is completed.

@alolita alolita added this to the Phase 2 Implementation milestone Jun 18, 2021
@alolita alolita assigned rsvarma95 and unassigned humivo and IrisTuntun Jul 27, 2021
@alolita
Copy link
Member

alolita commented Aug 25, 2021

PR open-telemetry/opentelemetry-operator#389 in the Operator repo is in review currently.

@alolita
Copy link
Member

alolita commented Sep 24, 2021

@Aneurysm9 is there anything else that needs to be done. The previous PRs have been merged.

@alolita alolita added the prom-receiver Prometheus receiver tasks label Sep 24, 2021
@Aneurysm9
Copy link
Member Author

This has been completed with the Operator's target allocation capability.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
phase2 phase2 tasks prom-receiver Prometheus receiver tasks
Projects
None yet
Development

No branches or pull requests

6 participants