Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

Support Prometheus histograms #18

Closed
RichiH opened this issue Feb 9, 2021 · 5 comments
Closed

Support Prometheus histograms #18

RichiH opened this issue Feb 9, 2021 · 5 comments
Assignees
Labels
data-model P0 An issue that needs to be addressed immediately. Breaking change.

Comments

@RichiH
Copy link
Member

RichiH commented Feb 9, 2021

Prometheus uses le, OTel uses ge bounded buckets. The two are mathematically incompatible and impossible to transform from one into the other.

@jmacd
Copy link

jmacd commented Feb 9, 2021

See also this current discussion about histograms in OTLP:

open-telemetry/opentelemetry-proto#226 (comment)

To be clear, that discussion has practically fallen apart, but it's a debate over an independent problem about locating the boundaries and encoding them compactly, not about >= vs <= question.

Whenever this has come up in the past, the issue gets sidelined with some technical argument about how histograms represent approximate a continuous probability distribution, not a discrete one, essentially to say that "it doesn't matter". I'm willing to say, at this point, that if "it doesn't matter" then OTLP should simply adopt the Prometheus "le" convention.

@RichiH
Copy link
Member Author

RichiH commented Feb 10, 2021

Agreed. There's nuance between the four possible boundary choices, but they are effectively/roughly equivalent if applied consistently on floats. Integer or discrete values are a niche use case and arguably better served by other mechanisms depending on specifics.

My main concern is user trust if their metrics pipelines behave subtly differently and they need to write complex queries to re-cast data on the fly.

Using le would make the whole problem space simply go away.

@bogdandrutu
Copy link
Member

I think this is the same as open-telemetry/opentelemetry-proto#258

@RichiH
Copy link
Member Author

RichiH commented Feb 14, 2021

Agreed, it's the same issue. I don't know what the plan with temporary duplications and deduplication is.

@bogdandrutu bogdandrutu self-assigned this Feb 17, 2021
@rakyll rakyll added the P0 An issue that needs to be addressed immediately. Breaking change. label Apr 7, 2021
@bogdandrutu
Copy link
Member

I think this is fixed, since OTLP changed to use "le". Please reopen if that is not the case

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
data-model P0 An issue that needs to be addressed immediately. Breaking change.
Projects
None yet
Development

No branches or pull requests

5 participants