From fc9cfa0223055d1307480d53ed8567c50b4e8a5d Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Fri, 11 Mar 2022 09:13:09 -0800 Subject: [PATCH 1/2] remove the MUST wording which requires exemplar to be on-by-default --- specification/metrics/sdk.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index 206f77d4d28..ba6a6dc4656 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -519,11 +519,8 @@ While the metric data point for the counter would carry the attributes `X` and A Metric SDK MUST provide a mechanism to sample `Exemplar`s from measurements via the `ExemplarFilter` and `ExemplarReservoir` hooks. -A Metric SDK MUST allow `Exemplar` sampling to be disabled. In this instance -the SDK SHOULD not have overhead related to exemplar sampling. - -A Metric SDK MUST sample `Exemplar`s only from measurements within the context -of a sampled trace BY DEFAULT. +`Exemplar` sampling SHOULD be turned off by default. If `Exemplar` sampling is +off, the SDK MUST NOT have overhead related to exemplar sampling. A Metric SDK MUST allow exemplar sampling to leverage the configuration of metric aggregation. For example, Exemplar sampling of histograms should be able From c4a8abb69971e32b11a1d99aabcdedab6248b5d3 Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Fri, 11 Mar 2022 09:25:13 -0800 Subject: [PATCH 2/2] update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8779f789db4..9e80557bb73 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -109,6 +109,8 @@ release. ([#2282](https://github.com/open-telemetry/opentelemetry-specification/pull/2282)) - Clarified wildcard and predicate support in metrics SDK View API. ([#2325](https://github.com/open-telemetry/opentelemetry-specification/pull/2325)) +- Changed the Exemplar wording, exemplar should be turned off by default. + ([#2414](https://github.com/open-telemetry/opentelemetry-specification/pull/2414)) ### Logs