Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic conventions for hardware metrics need to be updated to merge network metrics and GPU IOs metrics #2805

Closed
bertysentry opened this issue Sep 15, 2022 · 0 comments · Fixed by #2942
Closed

Semantic conventions for hardware metrics need to be updated to merge network metrics and GPU IOs metrics #2805

bertysentry opened this issue Sep 15, 2022 · 0 comments · Fixed by #2942
Assignees
@bertysentry
Labels
area:semantic-conventions Related to semantic conventions [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:metrics Related to the specification/metrics directory

Comments

@bertysentry
Copy link
Contributor

Following discussion in #2726, the semantic conventions for hardware metrics (specification\metrics\semantic_conventions\hardware-metrics.md) must be updated to merge IO metrics using the direction attribute:

Current metris Merged metric
hw.gpu.io.receive, hw.gpu.io.transmit hw.gpu.io with direction set to receive or transmit
hw.network.io.receive, hw.network.io.transmit hw.network.io with direction set to receive or transmit
hw.network.packets.receive, hw.network.packets.transmit hw.network.packets with direction set to receive or transmit
@bertysentry bertysentry added the spec:miscellaneous For issues that don't match any other spec label label Sep 15, 2022
@reyang reyang added the area:semantic-conventions Related to semantic conventions label Sep 15, 2022
@rbailey7210 rbailey7210 added the [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR label Sep 16, 2022
@arminru arminru added spec:metrics Related to the specification/metrics directory and removed spec:miscellaneous For issues that don't match any other spec label labels Sep 20, 2022
@bertysentry bertysentry mentioned this issue Nov 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bertysentry bertysentry

Labels
area:semantic-conventions Related to semantic conventions [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update semconv for hardware metrics to use direction attributes
5 participants
@yurishkuro @arminru @reyang @bertysentry @rbailey7210