From b1ca0b3dcb44e6cdd1e9783ea44edaf7c63b4179 Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Tue, 15 Mar 2022 11:04:59 -0700 Subject: [PATCH] Remove the "MUST" wording which requires exemplar to be on-by-default (#2414) --- CHANGELOG.md | 2 ++ specification/metrics/sdk.md | 7 ++----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e7e897393fa..fc3ecfd0d91 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -111,6 +111,8 @@ release. ([#2282](https://github.com/open-telemetry/opentelemetry-specification/pull/2282)) - Clarified wildcard and predicate support in metrics SDK View API. ([#2325](https://github.com/open-telemetry/opentelemetry-specification/pull/2325)) +- Changed the Exemplar wording, exemplar should be turned off by default. + ([#2414](https://github.com/open-telemetry/opentelemetry-specification/pull/2414)) ### Logs diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index 2f153daa379..cd9746c43a8 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -519,11 +519,8 @@ While the metric data point for the counter would carry the attributes `X` and A Metric SDK MUST provide a mechanism to sample `Exemplar`s from measurements via the `ExemplarFilter` and `ExemplarReservoir` hooks. -A Metric SDK MUST allow `Exemplar` sampling to be disabled. In this instance -the SDK SHOULD not have overhead related to exemplar sampling. - -A Metric SDK MUST sample `Exemplar`s only from measurements within the context -of a sampled trace BY DEFAULT. +`Exemplar` sampling SHOULD be turned off by default. If `Exemplar` sampling is +off, the SDK MUST NOT have overhead related to exemplar sampling. A Metric SDK MUST allow exemplar sampling to leverage the configuration of metric aggregation. For example, Exemplar sampling of histograms should be able