Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal logging in BatchProcessor when buffer full #2273

Closed
cijothomas opened this issue Nov 5, 2024 · 1 comment · Fixed by #2357
Closed

Internal logging in BatchProcessor when buffer full #2273

cijothomas opened this issue Nov 5, 2024 · 1 comment · Fixed by #2357
Assignees
Labels
A-common Area:common issues that not related to specific pillar help wanted Good for taking. Extra help will be provided by maintainers/approvers

Comments

@cijothomas
Copy link
Member

Opening a separate issue to specifically tracking internal logging when BatchProcessor gets full.
#2175 (comment)

  1. We certainly don't want to log each time the buffer is full
  2. A good balance might be to keep a count of items-dropped-due-to-buffer-full.
  3. This count can be exposed as a Metric itself.
  4. And/Or this count can be emitted as a internal log upon shutdown/drop with severity WARN if non-zero items were dropped.

2,4 is what OTel .NET has implemented: See https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/BatchExportProcessor.cs#L102 and https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/BatchExportProcessor.cs#L207

@cijothomas cijothomas added help wanted Good for taking. Extra help will be provided by maintainers/approvers A-common Area:common issues that not related to specific pillar labels Nov 5, 2024
@scottgerring
Copy link
Contributor

Hey @cijothomas , I can pick this one up !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-common Area:common issues that not related to specific pillar help wanted Good for taking. Extra help will be provided by maintainers/approvers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants