Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize on instrumentation detection patterns #895

Closed
toumorokoshi opened this issue Jul 10, 2020 · 3 comments
Closed

standardize on instrumentation detection patterns #895

toumorokoshi opened this issue Jul 10, 2020 · 3 comments
Labels

Comments

@toumorokoshi
Copy link
Member

We should consider a standard for marking objects as instrumented by opentelemetry. There are a couple conventions that exist now:

  • setting the _is_instrumented attribute
  • setting the _is_instrumented_by_opentelemetry attribute

We should choose one, and maybe provide some patterns to reduce the code duplication.

@lzchen
Copy link
Contributor

lzchen commented Jul 10, 2020

I like _is_instrumented_by_opentelemetry in case other libraries want to "instrument" as well it avoids collisions.

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

This issue was marked stale due to lack of activity. It will be closed in 30 days.

@codeboten
Copy link
Contributor

Closing in favour of open-telemetry/opentelemetry-python-contrib#439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants