Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pymemcache instrumenter version selector is for very old package version #842

Closed
ij1 opened this issue Dec 29, 2021 · 2 comments · Fixed by #935
Closed

Pymemcache instrumenter version selector is for very old package version #842

ij1 opened this issue Dec 29, 2021 · 2 comments · Fixed by #935

Comments

@ij1
Copy link

ij1 commented Dec 29, 2021

Is your feature request related to a problem?
Any recent pymemcache package triggers an error due to version selector in its instrumenter:
DependencyConflict: requested: "pymemcache ~= 1.3" but found: "pymemcache 3.5.0"

Describe the solution you'd like
Up the pymemcache instrumenter's version selector.

Describe alternatives you've considered
Either no telemetry from pymemcache or major downgrade for pymemcache package. Neither seems optimal.

@srikanthccv
Copy link
Member

Are there any major breaking changes in version 2.x and 3.x? If not, it should be easier to bump the supported versions.

@ij1
Copy link
Author

ij1 commented Jan 15, 2022

While I've only recently migrated to pymemcache myself, going through the changelogs seemed like no changes to major API functions (there are tweaks to function parameter but I guess they're not meaningful from telemetry PoV).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants