Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out health check request in grpc #373

Closed
ymotongpoo opened this issue Mar 18, 2021 · 14 comments · Fixed by #1241
Closed

Filter out health check request in grpc #373

ymotongpoo opened this issue Mar 18, 2021 · 14 comments · Fixed by #1241
Assignees
Labels
feature-request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ymotongpoo
Copy link

Is your feature request related to a problem?
As of 0.18b1, opentelemetry-instrumentation-grpc doesn't have the feature to exclude trace propagation to the specific endpoints. Because of this, gRPC servers always send health check request traces to the backend via the exporter as you see in the screenshot below:
image

Describe the solution you'd like
It would be nice if opentelemetry-instrumentation-grpc could have something similar to OTEL_PYTHON_FLASK_EXCLUDED_URLS in opentelemetry-instrumentation-flask.

Describe alternatives you've considered
Each exporters support filter option to avoid sending unnecessary traces to the backend.

Additional context
Health checking is the common practice in Kubernetes and the traces for such requests sometimes pollute the Trace dashboard and leads to unnecessary costs for SaaS services.

@jan25
Copy link
Contributor

jan25 commented Apr 11, 2021

I could give this a shot if not already picked up :)

@lzchen
Copy link
Contributor

lzchen commented Apr 12, 2021

@jan25
Sure thing.

@rahulgupta92
Copy link
Contributor

Is this feature being worked upon or has been implemented? Any suggestions/workarounds for excluding such requests?

@lzchen
Copy link
Contributor

lzchen commented Jun 8, 2022

@jan25
Any updates on this?

@avzis
Copy link
Contributor

avzis commented Aug 4, 2022

@lzchen @ymotongpoo
I'm looking for a good first issue, is this still relevant?

@ymotongpoo
Copy link
Author

@avzis Yes, I think so. I'm working on Go version in open-telemetry/opentelemetry-go-contrib#2572, and you can port it to Python.

@lzchen
Copy link
Contributor

lzchen commented Aug 9, 2022

@avzis
I'll assign this to you.

@lzchen lzchen assigned avzis and unassigned jan25 Aug 9, 2022
@ymotongpoo
Copy link
Author

ymotongpoo commented Aug 17, 2022

So, is @avzis working on this now? Because open-telemetry/opentelemetry-go-contrib#2572 is merged, now I can port it to Python soon if necessary.

@lzchen
Copy link
Contributor

lzchen commented Aug 18, 2022

@avzis
Are you currently working on this? I can assign it to @ymotongpoo if not.

@avzis
Copy link
Contributor

avzis commented Aug 23, 2022

hi, yes

@lzchen lzchen assigned ymotongpoo and unassigned avzis Aug 23, 2022
@lzchen
Copy link
Contributor

lzchen commented Aug 23, 2022

@avzis

hi, yes

Will be taking this as "yes you can assign it to someone else". Please comment if otherwise.

@avzis
Copy link
Contributor

avzis commented Aug 24, 2022

i mean "yes i'm working on it", sorry for not being clear

@ymotongpoo
Copy link
Author

oh, I have implemented mostly in #1241 but for unit tests.

@avzis
Copy link
Contributor

avzis commented Aug 24, 2022

ok, so you finish it..
ill take another issue
good luck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants