-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out health check request in grpc #373
Comments
I could give this a shot if not already picked up :) |
@jan25 |
Is this feature being worked upon or has been implemented? Any suggestions/workarounds for excluding such requests? |
@jan25 |
@lzchen @ymotongpoo |
@avzis Yes, I think so. I'm working on Go version in open-telemetry/opentelemetry-go-contrib#2572, and you can port it to Python. |
@avzis |
So, is @avzis working on this now? Because open-telemetry/opentelemetry-go-contrib#2572 is merged, now I can port it to Python soon if necessary. |
@avzis |
hi, yes |
Will be taking this as "yes you can assign it to someone else". Please comment if otherwise. |
i mean "yes i'm working on it", sorry for not being clear |
oh, I have implemented mostly in #1241 but for unit tests. |
ok, so you finish it.. |
Is your feature request related to a problem?
As of 0.18b1,
opentelemetry-instrumentation-grpc
doesn't have the feature to exclude trace propagation to the specific endpoints. Because of this, gRPC servers always send health check request traces to the backend via the exporter as you see in the screenshot below:Describe the solution you'd like
It would be nice if opentelemetry-instrumentation-grpc could have something similar to
OTEL_PYTHON_FLASK_EXCLUDED_URLS
inopentelemetry-instrumentation-flask
.Describe alternatives you've considered
Each exporters support filter option to avoid sending unnecessary traces to the backend.
Additional context
Health checking is the common practice in Kubernetes and the traces for such requests sometimes pollute the Trace dashboard and leads to unnecessary costs for SaaS services.
The text was updated successfully, but these errors were encountered: